Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Нужно больше функций #3

Merged
merged 4 commits into from
Nov 23, 2024
Merged

Нужно больше функций #3

merged 4 commits into from
Nov 23, 2024

Conversation

Daniil888-m
Copy link
Contributor

@Daniil888-m Daniil888-m commented Nov 21, 2024 •
edited by keksobot
Loading

craz3r
craz3r requested changes Nov 22, 2024
View reviewed changes
js/functions.js Outdated

checkStr('fff', 3);

function isPalimdrome(string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isPalindrome

js/functions.js

function isPalimdrome(string) {
string = string.replaceAll(' ', '');
const reversedString = string.split('').reverse().join('');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не учтен случай, когда строка содержит символы в разном регистре

@keksobot keksobot merged commit b6737a4 into htmlacademy-javascript:master Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craz3r craz3r craz3r requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniil888-m @craz3r @keksobot